Improve gas coord state compact #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act state structure
⛽ Gas Usage ChangesComparison against Click to view gas difftest_getCoordStorage_IsIsolated() (gas: +442 (2.141%))
test_getAuthStorage_IsIsolated() (gas: +479 (2.351%))
test_getTxStorage_IsIsolated() (gas: +541 (2.624%))
test_handleAck_RevertWhen_StateNotFound() (gas: +10340 (8.294%))
test_handleAck_RevertWhen_CoordinatorStateNotFound() (gas: -28202 (-9.080%))
test_runTx_RevertWhen_ChannelNotFound() (gas: +10341 (12.197%))
test_runTx_RevertWhen_UnexpectedReturnValue() (gas: +10339 (14.453%))
test_handleAck_RevertWhen_ChannelNotFound() (gas: -47440 (-14.819%))
test_handleAck_RevertWhen_ChannelMismatch() (gas: -48842 (-15.200%))
test_runTx_SucceedsAndSendsPacket() (gas: -52145 (-15.248%))
test_handleAck_RevertWhen_CoordinatorPhaseNotPrepare() (gas: -46608 (-15.259%))
test_handleAck_RevertWhen_InvalidTxIDLength() (gas: -50969 (-15.592%))
test_handleAck_RevertWhen_PacketTypeURLUnexpected() (gas: -50969 (-16.139%))
test_handleAck_RevertWhen_PacketPayloadDecodeFailed() (gas: -50969 (-18.320%))
test_handleAck_RevertWhen_AllTransactionsConfirmed() (gas: -68764 (-19.507%))
test_handleAck_RevertWhen_AckTypeURLUnexpected() (gas: -50969 (-19.628%))
test_handleAck_RevertWhen_UnexpectedCommitStatus() (gas: -69218 (-20.295%))
test_handleAck_RevertWhen_AckPayloadDecodeFailed() (gas: -50969 (-21.041%))
test_handleAck_RevertWhen_AckIsNotSuccess() (gas: -50969 (-21.988%))
test_runTx_RevertWhen_TxIDAlreadyExists() (gas: -46545 (-22.353%))
test_handleAck_Failure() (gas: -110057 (-24.342%))
test_handleAck_Success() (gas: -110052 (-24.362%))
test_handleAck_RevertWhen_OnAbortReverts() (gas: -109903 (-24.433%))
test_handleAck_RevertWhen_OnCommitReverts() (gas: -109898 (-24.456%))
test_runTx_RevertWhen_Tx0NotLocal() (gas: +10337 (24.685%))
test_handleAck_RevertWhen_CoordinatorStateInconsistent() (gas: -108401 (-26.267%))
test_getCoordinatorState_ReturnsCorrectState() (gas: -20150 (-27.140%))
test_handleAck_RevertWhen_CoordinatorTxStatusNotPrepare() (gas: -109933 (-27.411%))
test_handleAck_RevertWhen_ModuleNotInitialized() (gas: -109900 (-27.820%))
test_runTx_RevertWhen_ModuleNotInitialized() (gas: +10338 (28.114%))
test_runTx_PrepareFailed() (gas: -91896 (-30.835%))
test_runTx_RevertWhen_LinksNotSupported() (gas: +10337 (36.922%))
test_getCoordinatorState_RevertsIfNotFound() (gas: +10211 (56.274%))
Overall gas change: -1520063 (-0.141%)
Calculated by Foundry Gas Snapshot Action |
LCOV of commit
|
YukiTsuchida
changed the title
mattsu6666
reviewed
Jan 16, 2026
| string participantChannel; | ||
|
|
||
| uint8 confirmedMask; // bit0=coord, bit1=participant | ||
| uint8 ackMask; // bit0=coord, bit1=participant |
Member
There was a problem hiding this comment.
I think it would be good to add a comment clarifying that this struct is only intended for a 1:1 relationship between the coordinator and the participant. It would also be good to note that introducing 2PC would require a redesign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
CoordStateCompactto replace the proto-generatedCoordinatorState.Datain storage. This allows us to pack protocol, phase, decision, and masks into a single slot.